Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code changes to support DEBUG compilation based on appBuilder file #23

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Code changes to support DEBUG compilation based on appBuilder file #23

merged 1 commit into from
Jan 21, 2020

Conversation

MinsukJi-NOAA
Copy link
Collaborator

  1. component_MOM6.mk sets the MOM6_MAKEOPT environment variable for compile.sh
  2. component_CICE.mk sets the CICE_MAKEOPT environment variable for comp_ice.backend

Resolves issue #22

@MinsukJi-NOAA
Code changes to support DEBUG compilation based on appBuilder specifi…
0a99403 
…cation

1. component_MOM6.mk sets the MOM6_MAKEOPT environment variable for compile.sh

2. component_CICE.mk sets the CICE_MAKEOPT environment variable for comp_ice.backend
@MinsukJi-NOAA
Copy link
Collaborator Author

  • Note that all regression tests for ufs-s2s-model passed.

@RatkoVasic-NOAA
Copy link
Collaborator

RatkoVasic-NOAA commented Jan 17, 2020 •
edited
Loading

  • Note that all regression tests for ufs-s2s-model passed.

Regression tests passed on Dell as well.

@MinsukJi-NOAA
Copy link
Collaborator Author

NEMSCompset regression tests all passed for ufs-weather-model on Hera.

DeniseWorthen
DeniseWorthen approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the correct DEBUG=Y flag is passed to both MOM6 and CICE5 during the build of the coupled app.

@MinsukJi-NOAA MinsukJi-NOAA merged commit daae388 into NOAA-EMC:develop Jan 21, 2020
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/nems_debug_flag branch January 21, 2020 15:19
@DeniseWorthen DeniseWorthen mentioned this pull request Jan 24, 2020
Merged
hyunchul386 pushed a commit to hyunchul386/NEMS that referenced this pull request Jul 24, 2020
@binli2337
Implement regression tests using shell scripts under tests directory (N…
68c4b59 
…OAA-EMC#23)

* Added tests for regression test system using rt.sh on Hera.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeniseWorthen DeniseWorthen DeniseWorthen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinsukJi-NOAA @RatkoVasic-NOAA @DeniseWorthen