more unit tests for code in gbits.c, gridtemplates, drstemplates, pdstemplates, plus doxygen improvements and code cleanup #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I will stop adding testing on this branch, and start a new one. THis branch takes testing up to ~20% coverage: |
edwardhartnett
changed the title
BrianCurtis-NOAA
approved these changes
Oct 25, 2021
| * | ||
| * @param[in] cgrib Character array to contain the GRIB2 message. Must | ||
| * be allocated large enough to store the entire GRIB2 message. | ||
| * @param[in] listsec0 Contains information needed for GRIB Indicator | ||
| * Section 0. Must be dimensioned >= 2. | ||
| * - listsec0[0]=Discipline-GRIB Master Table Number (see Code Table 0.0) | ||
| * - listsec0[1]=GRIB Edition Number (currently 2) | ||
| * - listsec0(0) Discipline-GRIB Master Table Number ([Code Table 0.0] |
There was a problem hiding this comment.
Fixed in next PR...
Comment on lines
+32
to
+41
| * - listsec1(0) Id of orginating centre ([Table 0] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/on388/table0.html)). | ||
| * - listsec1(1) Id of orginating sub-centre ([Table C] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/on388/tablec.html)). | ||
| * - listsec1(2) GRIB Master Tables Version Number ([Table 1.0] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table1-0.shtml)). | ||
| * - listsec1(3) GRIB Local Tables Version Number ([Table 1.1] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table1-1.shtml)). | ||
| * - listsec1(4) Significance of Reference Time ([Table 1.2] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table1-2.shtml)) |
There was a problem hiding this comment.
Fixed in next PR...
Comment on lines
+48
to
+51
| * - listsec1(11) Production status of data ([Table 1.3] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table1-3.shtml)). | ||
| * - listsec1(12) Type of processed data ([Table 1.4] | ||
| * (https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table1-4.shtml)). |
There was a problem hiding this comment.
Fixed in next PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8.
More unit tests for the functions in gbits.c and gridtemplates.c. Also documentation improvements.