Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#342. feature/ascat-fix: update thinning and observation error for ASCAT winds #343

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

emilyhcliu
Copy link
Contributor

Update observation error and thinning for ASCAT.
Two fix files were modified:

  1. global_convinfo.txt (for thinning box)
  2. prepobs_errtable.global (for observation error)

issus#342

@MichaelLueken
Copy link
Contributor

Hi @emilyhcliu, since there are no changes to source code files, I can move forward with this change once the work currently out for to the review committee has been merged to the authoritative repo. Before I merge this work, however, please use:

git commit --amend

to add:

GitHub Issue NOAA-EMC/GSI#342

to your commit message, then save and close the commit message window, and wrap up with:

git push origin feature/ascat --force

to push the amended commit message to the repo. Also, will this work wrap up issue #342, or will there be additional work, so the issue should remain open? Thanks.

@emilyhcliu
Copy link
Contributor Author

@MichaelLueken-NOAA just push the additional entry to my commit.

@emilyhcliu
Copy link
Contributor Author

Hi @emilyhcliu, since there are no changes to source code files, I can move forward with this change once the work currently out for to the review committee has been merged to the authoritative repo. Before I merge this work, however, please use:

git commit --amend

to add:

GitHub Issue NOAA-EMC/GSI#342

to your commit message, then save and close the commit message window, and wrap up with:

git push origin feature/ascat --force

to push the amended commit message to the repo. Also, will this work wrap up issue #342, or will there be additional work, so the issue should remain open? Thanks.

@MichaelLueken-NOAA Nope, there will be no additional work for issue #342. It can be closed once this commit is merged. Thank you.

@MichaelLueken MichaelLueken linked an issue Mar 23, 2022 that may be closed by this pull request
2 tasks
@MichaelLueken
Copy link
Contributor

Since this work is only updating two fix files (with no changes to the source code), I will now give final approval to these changes and merge them to the authoritative repository.

@MichaelLueken MichaelLueken changed the title feature/ascat-fix: update thinning and observation error for ASCAT winds GitHub Issue NOAA-EMC/GSI#342. feature/ascat-fix: update thinning and observation error for ASCAT winds Mar 23, 2022
@MichaelLueken MichaelLueken merged commit ef237ce into NOAA-EMC:master Mar 23, 2022
AndrewEichmann-NOAA pushed a commit to AndrewEichmann-NOAA/GSI that referenced this pull request Jun 6, 2022
GitHub Issue NOAA-EMC#342. feature/ascat-fix: update thinning and observation error for ASCAT winds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add changes for ASCAT winds for v16.x implementation
2 participants