-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NCO Bugzilla Tickets opened with GFS v16 DA #137
Comments
Additional details regarding the above NCO bugzillas are found in google doc GFS v16 DA bugzillas. NOTE: Most of the information from the above google doc has been included in this issue as comments below. |
Bugzilla 1196 Bugzilla 1198 Numerous occurrences of
None of the above files are used by NCEP operations. Some of the above may not even be used by developers. Obsolete files should be removed from the NOAA-EMC/GSI repository. When creating a release branch or tag for NCO, files and directories not used by the package being implemented should be removed from the release branch or tag. This along with removing obsolete files from the NOAA-EMC/GSI repository should satisfy the requirements of bugzilla 1198. Bugzilla 1198 may be closed upon NCO's review and approval of changes committed at f808885 along with clean up procedure outline above. |
Bugzilla 1205 The updated Bugzilla 1206 Bugzilla 1206 may be closed upon NCO's review and approval. |
Cross link with corresponding global-workflow issues The changes requested in several GFS v16 DA bugzillas also include other GFS v16 components. These multi-component bugzillas have corresponding global-workflow issues. The table below maps bugzillas reported in this NOAA-EMC/GSI issue to corresponding global-workflow issues.
|
Bugzilla 1214
To the extent that the above response is satisfactory, bugzilla 1214 may be closed upon NCO's review and approval. |
Bugzilla 216 One large step toward reducing the number of "go to" in GFS DA is to remove all files from the GFS DA release branch that are not required to run GFS DA in operations. The "go to" that remain in the GFS DA release branch after this pruning should be examined and removed as possible. |
Bugzilla 1212 Issue #123 addresses this bugzilla with regards to how it pertains to OznMon. As noted above, other pieces of GFS DA need to examined for compliance with the stated standards in bugzilla 1212. |
Bugzilla 1218
These options and possibly new options, too, should be explored in future GFS DA implementations. |
Bugzilla 1221
The Issue #123 will resolve bugzilla 1221 for |
Bugzilla 1222
The hardwired paths for Note that GFS DA release branches up to and including GFS DA v16 have only pruned |
Changes committed to release/gfsda.v16.1.0 at 532fa23 address the following NCO GFS v16 DA bugzillas. Please see issue #120 for additional information. Bugzilla 1221 Bugzilla 1222
Bugzilla 216 None of the changes committed to release/gfsda.v16.1.0 at 532fa23 alter analysis results. |
Bugzilla 1221 |
Update this issue with a review of the above 12 DA related bugzillas with respect to release/gfsda.v16.3.0 Bugzilla 216 An updated In order to activate the prune option for GFS v16.3.0, the |
Bugzilla 1196 This bugzilla, improve error message in gfs_atmos_analysis job for missing enkf input, has been re-examined using release/gfsda.v16.3.0. Previous statements regarding improved messaging when encountering missing or zero length input atmospheric and surface hi-res and enkf input files remain valid. Below is a sample of tests run on WCOSS2 and the resulting error message: missing
missing zero length
missing
missing
zero length
missing
missing
zero length
missing
|
Bugzilla 1198 This bugzilla, Improve error handling to use err_chk/err_exit in gfs scripts, has been re-examined using The following gfsda.v16.3.0 scripts are found to reference
None of these scripts are used in the operational gfsda.v16.3.0 package. As such, these files may be removed during the installation of the gfs.v16.3.0 package. gdsda.v16.3.0 script A check of the installed gfs.v16.3.0 package with the prune script active finds no occurrences of The recommended action for this bugzilla with regards to the DA component is to activate the prune option in g-w
The recommendation is to uncomment the
With this change the above gfsda.v16.3.0 scripts will be removed from the gfs.v16.3.0 installation. |
Bugzillas 1205 and 1206 These bugzillas,
have be re-examined in the context of The following lines were added to
As explained in bugzilla 1205, the After compiling all gfsda.v16.3.0 executables with
Note that The discussion which follows pertains to bugzilla 1205. The errors caught by
One of the errors, an example of shape mismatch, is discussed at length in GSI issue #256. Source code changes were made to correct the errors identified by compiling and running with The g-w was used to run a cycled parallel from 2021110806 through 2021110900 with the updated executables. All jobs in all cycles ran to completion. The results from the test were saved and the same period cycled through again using exectuables built from the original, unaltered This test indicates the that changes to the NCO may close bugzilla 1205 with acceptance of the changes committed at 053e447. |
Bugzilla 1196 Given NCO feedback, add FATAL to error message string. The previously run tests were rerun on WCOSS2 with the revised error message. Below are the updated error messages: missing
missing
zero length
missing
missing
zero length
missing
missing
zero length
missing
The changes required for the above changes were committed to Russ.Treadon-NOAA/release/gfsda.v16.3.0 at a1dfd2c NCO also requests the full path and source filename be written to run time output in the event of a missing atm or sfc input file. The Since the GSI supports a variety in input/output formats for atm and sfc files, If the full path along with the source filename is necessary, extensive changes will need to be made to the GSI. If this is necessary, time should be taken to design a robust, easy to install, and easy to maintain approach. This effort should be undertaken by the DA code manager in conjunction with EIB to ensure a consistent approach across all DA and, hopefully, all GFS apps. |
Bugzilla 1210 While GFS DA is not mentioned in this bugzilla, the request made in this bugzilla is good for DA developers to be aware of and adhere to. A check of DA jobs in
The uses of The use of The current NOAA-EMC/GSI Furthermore, DA jobs and scripts, including those for DA verification, are being moved out GSI based repositories and into global-workflow As such, aligning DA verification jobs with bugzilla 1210 in a future implementation will need to be done via an issue and PR opened in NOAA-EMC/global-workflow. Please see global-workflow issue NOAA-EMC/global-workflow#289 for additional information on this bugzilla. |
Bugzilla 1212 Resolution of this bugzilla involves more than just GFS DA. Resolution of the five items in this bugzilla requires a top down and bottom up sweep of all GFS The above noted,
Instead of setting and using *
A check of g-w
The appropriate default for
The use of While GFS v16.3.0 represents a step in the right direction for bugzilla 1212, more work remains. While still daunting it may prove easier to tackle bugzilla 1212 once |
Bugzilla 1214 As mentioned above, GFS DA may be done with this bugzilla.
|
Bugzilla 1216 The issue noted in this bugzilla, erroneous missing file warnings, has been addressed via issue #123 and PR #144. A check of For example, the 2022081900 run flagged the following ozone satellite_sensor diagnostic files as missing
A check of the oznstat tarball confirms this
This bugzilla may be closed pending approval from NCO. |
Bugzilla 1218 This bugzilla addresses the build for multiple GFS v16 applications. The initial DA response to this bugzilla found in comments earlier in this issue. The build and installation of
to
As delivered script Bugzilla 1218 refers to
When the
Since bugzilla 1218 addresses more than just GFS DA components, the above changes are not sufficient to close this bugzilla. The above, however, demonstrates, that the DA component of GFS v16.3.0 is, hopefully, in alignment with the intent of bugzilla 1218. Confirmation of this must be provided by NCO. |
…in MinMon_config in lieu of prod_util definition (NOAA-EMC#137)
Bugzilla 1221 As described in comments above, issue #123 addressed the DA aspect of this bugzilla. A check of the offending DA scripts, A check of a pruned (
The With this change only the A check for
The Variable
As such, With these changes |
…ventional_Monitor for BUILD_UTIL_MON option (NOAA-EMC#137)
Bugzilla 1222 Comments pertaining to this bugzilla are found above in this issue.
A check of the pruned directory tree found the Hera path
No action will be taken at present with regards to the above instances of One item of note loosely associated with bugzilla 1222.
This section should be removed because RFC 9881 installed Execution of g-w The changes documented above move this bugzilla closer to closure with respect to GFS DA v16.3.0 components. These changes alone do not warrant closing bugzilla 1222. This bugzilla touches more than just the GFS DA component. |
PR #456 was merged into the authoritative As noted in the description of this issue, most of the 12 bugzillas listed in this issue are NOT DA-only bugzillas. The majority of the bugzillas refer to the GFS of which DA is one component. An attempt has been made to address the DA component in the GFS bugzillas. 4 of the 12 bugzillas are limited to DA alone. Changes now in the authoritative The table below separates the 12 bugzillas mentioned in this issue into GFS and DA-only bugzillas
|
Closing this issue given the merger of PR #456 into |
NCO opened numerous GFS v16 related bugzilla tickets which must be addressed in future GFS implementations. Some of NCO's bugzilla tickets are DA specific. Others include DA as one component of the larger issue raised in the bugzilla ticket. This issue is opened in NOAA-EMC/GSI to track resolution of the DA component of the following NCO bugzilla tickets:
This issue should be referred to and updated with the specific NOAA-EMC/GSI issues that address the above NCO bugzillas. The above bugzillas will be checked completed as they are resolved in other NOAA-EMC/GSI issues.
The text was updated successfully, but these errors were encountered: