Add and modify module files to compile on AWS #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modulefiles/noaacloud-run.intel.lua
Outdated
| local stack_intel_ver=os.getenv("stack_intel_ver") or "2021.3.0" | ||
| local stack_impi_ver=os.getenv("stack_impi_ver") or "2021.3.0" | ||
| local grads_ver=os.getenv("grads_ver") or "2.2.3" | ||
| local perl_ver=os.getenv("perl_ver") or "5.38.0" |
There was a problem hiding this comment.
Is perl_ver needed if there's no perl module loaded here?
|
Ed,
Nice catch!
perl is not needed, and therefor now need to define here.
I have the line removed and pushed in a new change.
Thank you,
Wei
…On Fri, Apr 26, 2024 at 7:58 AM Ed Safford ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In modulefiles/noaacloud-run.intel.lua
<#136 (comment)>:
> @@ -0,0 +1,19 @@
+help([[
+]])
+
+prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/unified-env/install/modulefiles/Core")
+
+local stack_intel_ver=os.getenv("stack_intel_ver") or "2021.3.0"
+local stack_impi_ver=os.getenv("stack_impi_ver") or "2021.3.0"
+local grads_ver=os.getenv("grads_ver") or "2.2.3"
+local perl_ver=os.getenv("perl_ver") or "5.38.0"
Is perl_ver needed if it isn't loaded here?
—
Reply to this email directly, view it on GitHub
<#136 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCH65HUWFOB57RWWK37TLY7JMRTAVCNFSM6AAAAABGZK66MOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRVGEZDGNBUG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
EdwardSafford-NOAA
approved these changes
Apr 26, 2024
|
Thank you!
…On Fri, Apr 26, 2024 at 8:57 AM Ed Safford ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, thanks.
—
Reply to this email directly, view it on GitHub
<#136 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCH66K63Y4Z3IY4FTVZNTY7JTODAVCNFSM6AAAAABGZK66MOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRVGI2TINJWGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and modify module files to compile GSI-utils on AWS,
resolve issure: #135
#135