-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to use zero-gradient BC to reconstruct interface u/v for height advection; change dz_min as a input #53
Conversation
… interface u/v with PSM for height advection 2)Change dz_min as a namelist input
Merge EMC dev/emc to GFDL dev/emc
New dependencies 01/20/2021NOAA-PSL/stochastic_physics#36 |
@junwang-noaa @DusanJovic-NOAA Please assign reviewers when you get the chance. Thanks! |
The diff makes it look like all of nh_utils.F90 has been re-written. What precisely are the differences in these two versions? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look fine for me. The dz_min adjustment now starts from the surface as SJ Lin coded . An option is added to apply non-slippery wind profile reconstruction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, as the original behavior can be recovered by namelist options at runtime. Every FV3 user needs to tailor the dynamics to their own needs. The reduction in order at the lower boundary may change the behavior of orographic flows and needs to be closely monitored. Problems arising from the physics need to be fixed rather than relying on the dynamics to cover them up. But otherwise the change is OK.
1)Add an option to use original BC or zero-gradient BC to reconstruct interface u/v with PSM for height advection
2)Change dz_min as a namelist input
##Issue(s) addressed
This is used to solve some model crashes in GFSv16 and regional forecasts.
##Testing
This is tested for GFSv16, regional forecast and idealized mountain wave tests.
This new BC option is not changing forecast performance and results significantly.
It is not change regression test baseline since the default setting remains the same as the original
##Dependencies
ufs-community/ufs-weather-model#369
NOAA-EMC/fv3atm#232