Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg of where soca is staged/run #210

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Reorg of where soca is staged/run #210

merged 2 commits into from
Nov 29, 2022

Conversation

guillaumevernieres
Copy link
Contributor

Description

I was staging everything in COMOUT when running the soca_prep and linking into RUNDIR in the run script. I was told not to do that, so here is a fix ...

Danger

I modified some of the "generic" code under ufsda.stage, but I think soca is the only application making use of the methods touched.

@guillaumevernieres guillaumevernieres added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Nov 29, 2022
@emcbot emcbot added hera-RT-Running Automated testing running on Hera orion-RT-Running Automated testing running on Orion and removed hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Nov 29, 2022
@emcbot
Copy link

emcbot commented Nov 29, 2022

Automated Pull Request Testing Results:
Machine: hera

Start: Tue Nov 29 02:00:21 UTC 2022 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Nov 29 02:37:27 UTC 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Nov 29 02:40:57 UTC 2022
Tests: 100% tests passed, 0 tests failed out of 22

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Nov 29, 2022
@emcbot
Copy link

emcbot commented Nov 29, 2022

Automated Pull Request Testing Results:
Machine: orion

Start: Mon Nov 28 20:00:38 CST 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Nov 28 20:45:40 CST 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Nov 28 21:24:30 CST 2022
Tests: 95% tests passed, 1 tests failed out of 22
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/PR/210/GDASApp/build/log.ctest

@emcbot emcbot added orion-RT-Failed Automated testing failed on Orion and removed orion-RT-Running Automated testing running on Orion labels Nov 29, 2022
@guillaumevernieres
Copy link
Contributor Author

The Orion test timed-out.

CoryMartin-NOAA
CoryMartin-NOAA approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

RussTreadon-NOAA
RussTreadon-NOAA approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does a resubmission of the orion-RT test run to completion?

Approve.

@CoryMartin-NOAA CoryMartin-NOAA added orion-RT Queue for automated testing on Orion and removed orion-RT-Failed Automated testing failed on Orion labels Nov 29, 2022
@emcbot emcbot added orion-RT-Running Automated testing running on Orion and removed orion-RT Queue for automated testing on Orion labels Nov 29, 2022
@CoryMartin-NOAA CoryMartin-NOAA added orion-RT Queue for automated testing on Orion and removed orion-RT-Running Automated testing running on Orion labels Nov 29, 2022
@emcbot emcbot added orion-RT-Running Automated testing running on Orion and removed orion-RT Queue for automated testing on Orion labels Nov 29, 2022
@emcbot
Copy link

emcbot commented Nov 29, 2022

Automated Pull Request Testing Results:
Machine: orion

Start: Tue Nov 29 10:45:32 CST 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Nov 29 11:19:59 CST 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Nov 29 11:27:21 CST 2022
Tests: 95% tests passed, 1 tests failed out of 22
100% tests passed, 0 tests failed out of 22

@emcbot emcbot added orion-RT-Passed Automated testing successful on Orion and removed orion-RT-Running Automated testing running on Orion labels Nov 29, 2022
@CoryMartin-NOAA CoryMartin-NOAA merged commit 41cf7c3 into develop Nov 29, 2022
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/reorg4gw branch November 29, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees
No one assigned
Labels
hera-RT-Passed Automated testing successful on Hera orion-RT-Passed Automated testing successful on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganization of the marine DA scratch dir test_gdasapp_soca_ana_prep failing on salt_profile_fnmoc
4 participants
@guillaumevernieres @emcbot @CoryMartin-NOAA @RussTreadon-NOAA