Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gsibec #170

Merged
merged 10 commits into from
Nov 7, 2022
Merged

Feature/gsibec #170

merged 10 commits into from
Nov 7, 2022

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR is opened to add GSI static B as a new option for the background error covariance used by fv3jedi_var.x.

Issue #166 documents the changes in branch feature/gsibec, This branch has been built on Hera and Orion. 3dvar tests have been successfully run using GSI static B on both machines.

Updates to the g-w to use GSI static B have been committed to g-w branch feature/staticb and are documented in g-w issue #1103. The combination of GDASApp branch feature/gsibec and g-w branch feature/staticb have been used to run a UFS DA cycling parallel on Hera.

@RussTreadon-NOAA
Copy link
Contributor Author

Note: The corresponding g-w changes are in g-w PR #1104.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review October 31, 2022 20:39
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and one question, thanks a lot @RussTreadon-NOAA for getting this going!

parm/atm/berror/staticb_gsibec.yaml Outdated Show resolved Hide resolved
parm/atm/berror/staticb_gsibec.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Nov 3, 2022
@emcbot emcbot added hera-RT-Running Automated testing running on Hera orion-RT-Running Automated testing running on Orion and removed hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Nov 3, 2022
@emcbot
Copy link

emcbot commented Nov 3, 2022

Automated Pull Request Testing Results:
Machine: hera

Start: Thu Nov  3 20:00:22 UTC 2022 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Nov  3 21:15:09 UTC 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Thu Nov  3 21:17:27 UTC 2022
Tests: 100% tests passed, 0 tests failed out of 18

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Nov 3, 2022
@emcbot
Copy link

emcbot commented Nov 3, 2022

Automated Pull Request Testing Results:
Machine: orion

Start: Thu Nov  3 15:04:33 CDT 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Nov  3 17:36:52 CDT 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Thu Nov  3 17:41:56 CDT 2022
Tests: 100% tests passed, 0 tests failed out of 18

@emcbot emcbot removed the orion-RT-Running Automated testing running on Orion label Nov 3, 2022
@emcbot emcbot added the orion-RT-Passed Automated testing successful on Orion label Nov 3, 2022
@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA and @guillaumevernieres , I do not plan on making any more changes to feature/gsibec. This PR is ready for review.

  • @guillaumevernieres , you already gave your approval but a subsequent commit by me made your review obsolete. Would you mind reviewing again?
  • @CoryMartin-NOAA , I see that you are on leave today. That fine. If you can review early next week, this is would much appreciated.

@KateFriedman-NOAA , once this PR is merged into GDASApp develop, I will open a short g-w PR to update the GDASApp hash in Externals.cfg and checkout.sh.

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @RussTreadon-NOAA .

parm/atm/berror/staticb_gsibec.yaml Show resolved Hide resolved
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks @RussTreadon-NOAA !

@CoryMartin-NOAA CoryMartin-NOAA merged commit 4bf653c into develop Nov 7, 2022
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/gsibec branch November 7, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-RT-Passed Automated testing successful on Hera orion-RT-Passed Automated testing successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants