-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update select JEDI hashes #1377
Conversation
When the GDASApp `sorc/fv3-jedi` hash is updated to [97e10d5](JCSDA-internal/fv3-jedi@97e10d5) or a hash after this commit, it is necessary, at a minimum, to update soil variables in the following templates ``` model/atmosphere/atmosphere_background.yaml.j2 model/atmosphere/atmosphere_background_ensemble.yaml.j2 ``` This PR is opened to update the soil variables in the above templates. Resolves #49 **NOTE**: GDASApp PR [#1377](NOAA-EMC/GDASApp#1377) requires this PR be merged into jcb-gdas `develop`. Once this is done, the `parm/jcb-gdas` hash in [#1377](NOAA-EMC/GDASApp#1377) should be updated to point at the new jcb-gdas `develop`.
Automated GW-GDASApp Testing Results:
|
Running full suite of gdasapp ctests, both GDASApp and g-w based, using g-w Based on last night's stable-nightly results all tests should pass. So far 110/134 tests have run and passed. Several g-w based jobs are PENDING in the queue. I'll update this PR with the full ctest results once all tests finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending successful completion of tests
jcb-algorithm PR #9 removes
I suspect other ctests will fail the reference check. I will update the references in Previous tests did not catch this because |
Thanks @RussTreadon-NOAA. Apologies, I let Guillaume remove the backward compatibility there. I didn't realize that would be included in the ref. |
No problem. The reference check is doing its job. |
d571f8d
Ugh, updating the reference file dismissed the approvals! @CoryMartin-NOAA, @danholdaway , or @DavidNew-NOAA : If you see this message would you please approve this PR. g-w based reference checks did not fail because g-w PR #3177 turned off reference checks in g-w based GDASApp ctests. We still need to update select reference files for g-w based ctests given jcb-algorithm PR #9, but we don't need to do so for this PR. |
Thank you @CoryMartin-NOAA ! I'll go ahead and merge. |
This PR updates select jedi hashes in
sorc
with recent JCSDA updates.Resolves: #1313
Resolves: #1407
Resolves: #1419
Depends