Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a gnu lua file for hercules #1341

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Addition of a gnu lua file for hercules #1341

merged 2 commits into from
Oct 18, 2024

Conversation

guillaumevernieres
Copy link
Contributor

I had to comment out da-utils in the bundle, but other than that the system builds.

@CoryMartin-NOAA
Copy link
Contributor

@guillaumevernieres what was the issue with da-utils?

@guillaumevernieres
Copy link
Contributor Author

@guillaumevernieres what was the issue with da-utils?

preprocessor stuff? I have enough distraction as is, so I just commented out and ignored!

/work/noaa/da/gvernier/sandboxes/global-workflow/sorc/gdas.cd/bundle/da-utils/src/regridStates/fv3_grid.F90:126:83:

  126 |      if(ESMF_logFoundError(rcToCheck=ierr,msg=ESMF_LOGERR_PASSTHRU,line=__LINE__,file=__FILE__)) &
      |                                                                                   1
Error: Unterminated character constant beginning at (1)

@CoryMartin-NOAA
Copy link
Contributor

ok @guillaumevernieres no problem, we can revisit this later if we need to

@guillaumevernieres guillaumevernieres merged commit 93e7ec6 into develop Oct 18, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/hercules-gnu-lua branch October 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

@danholdaway danholdaway Awaiting requested review from danholdaway

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a lua file for gnu/spack-stack 1.7 on Hercules
2 participants
@guillaumevernieres @CoryMartin-NOAA