-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update select JEDI hashes #1310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have yet to update the # for `jcb-gdas`. This will be done when [/NOAA-EMC/jcb-gdas/pull/30](NOAA-EMC/jcb-gdas#30) is merged. This branch requires changes in the `global-worflow` as well, see here: [https://github.com/guillaumevernieres/global-workflow/tree/feature/update_hashes](https://github.com/guillaumevernieres/global-workflow/tree/feature/update_hashes) . We'll need to update the # and coordinate the merge ...
7 tasks
danholdaway
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your diligent and hard work on this @RussTreadon-NOAA
CoryMartin-NOAA
approved these changes
Oct 4, 2024
DavidNew-NOAA
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for getting the latest FV3-JEDI hash in there
WalterKolczynski-NOAA
pushed a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Oct 26, 2024
Updates to the `gdas.cd` #. @RussTreadon-NOAA will submit a PR in the GDASApp, we'll update the gdas.cd # in this branch after the GDASApp PR is merged. In the mean time, could somebody review the few simple code changes that are needed to run with the new #? - [x] Depends on GDASApp PR [#1310](NOAA-EMC/GDASApp#1310) - [x] Depends on g-w issue [#3012](#3012) --------- Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com> Co-authored-by: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates JEDI hashes using
ush/submodules/update_develop.sh
. This script updates the hash forChanges in
soca
also required an update to submodulejcb-gdas
as well as other soca yamls.The changes to
soca
require updates to g-w marine DA python scripts. g-w PR # has been opened to get this changes into g-w. Thesorc/gdas.cd
hash in g-w PR # will be updated once this PR is merged into GDASAppdevelop
.Resolves #1298