-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yamls for JPSSRR sea-ice obs in cycling test #1300
base: develop
Are you sure you want to change the base?
Conversation
minvalue: 0.0 | ||
maxvalue: 1.0 | ||
#- filter: Background Check | ||
# threshold: 5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this background check filter commented out? If not, then delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point but now as same as what amsr2
has
minvalue: 0.0 | ||
maxvalue: 1.0 | ||
#- filter: Background Check | ||
# threshold: 5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as the *north.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same answer above
maxvalue: 1.0 | ||
#- filter: Background Check | ||
# threshold: 5.0 | ||
- filter: Domain Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a domain check for sea_surface_temperature > 2.0 and also > 0? Isn't one sufficient?
@@ -15,6 +15,8 @@ observers: | |||
# Ice concentration | |||
- !INC ${MARINE_OBS_YAML_DIR}/icec_amsr2_north.yaml | |||
- !INC ${MARINE_OBS_YAML_DIR}/icec_amsr2_south.yaml | |||
#- !INC ${MARINE_OBS_YAML_DIR}/icec_viirs_n20_l2_north.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to comment this out? Same question for "south"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not part of CI
yet, we will need to comment out when we have to use them-
Does the figure above has all the obs for the cycle? If so, there's probably a bug somewhere @apchoiCMD . |
This PR is to add the yaml keys
NH
andSH
, please see inyamls
andobsprep_config.yaml
Related to #1259