Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update soca scripts and tests to work with wxflow changes #1195

Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

Several soca ctests failed when run from a Hera installation of g-w PR #2700. Examination of output from the failed jobs pointed to issues related to wxflow and g-w PR #2654. Updates were made to select soca files to restore soca ctests to Passed state.

Resolves #1192

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA and @guillaumevernieres : I used g-w PR #2654 as a guide to tweak soca scripts. Even though all test_gdasapp_soca tests pass with these changes, this doesn't mean the changes are correct.

Your review of the changes would be greatly appreciated.

Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward; looks good. I didn't realize there were references to Task.config and Task.run_config outside of ush/python/pygfs/task. Thanks for the debugging

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @DavidNew-NOAA for the weekend review!

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RussTreadon-NOAA , sorry I didn't get around to working on this earlier.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jun 23, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jun 23, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @guillaumevernieres for your review and approval.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 7ef7d08 into NOAA-EMC:develop Jun 23, 2024
6 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/soca_ctests branch June 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Running Automated testing with global-workflow running on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soca ctests failing
4 participants