Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gfs_cyc dependency and replace CDUMP #137

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Remove gfs_cyc dependency and replace CDUMP #137

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
888ef9c
Remove cycle check
WalterKolczynski-NOAA Sep 11, 2024
fc52cf8
Replace CDUMP with RUN for global
WalterKolczynski-NOAA Sep 17, 2024
8f0428b
Fix check of cyc2run
WalterKolczynski-NOAA Sep 17, 2024
b2ee80c
Update STEP_GFS to INTERVAL_GFS and remove remaining gfs_cyc
WalterKolczynski-NOAA Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions ush/run_verif_global_in_global_workflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,12 @@
##---------------------------------------------------------------------------
##---------------------------------------------------------------------------

# Set default run cycle based on gfs_cyc
if [ $gfs_cyc = 1 ]; then
export cyc2run="$cyc"
elif [ $gfs_cyc = 2 ]; then
export cyc2run=12
elif [ $gfs_cyc = 4 ]; then
export cyc2run=18
else
echo "EXIT ERROR: gfs_cyc must be 1, 2 or 4."
exit 1
fi

export SDATE_GFS=${SDATE_GFS:-$SDATE}
export EDATE_GFS=${EDATE_GFS:-$EDATE}
export VDATE="${VDATE:-$(echo $($NDATE -${VRFYBACK_HRS} $CDATE) | cut -c1-8)}"

cyc2run="${cyc}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the way verif-global is run. I think this is OK since it is not going to be operational, but just noting that it will now run every GFS cycle instead of once per day.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow is only running it at 18z, so it will function similarly to before.


start_ymd=${SDATE_GFS:0:8}
# Check if we are on the first YMD
if [[ ${start_ymd} == ${VDATE} ]]; then
Expand All @@ -38,11 +28,6 @@ if [[ ${end_ymd} == ${VDATE} ]]; then
cyc2run=${EDATE_GFS: -2}
fi

if [[ ${cyc2run} != ${cyc} ]]; then
echo "Skipping ${METPCASE} for cycle ${cyc}, will be run on cycle ${cyc2run}"
exit 0
fi

end_cyc=${cyc2run}
verf_step=${STEP_GFS:-24}
WalterKolczynski-NOAA marked this conversation as resolved.
Show resolved Hide resolved

WalterKolczynski-NOAA marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -64,7 +49,7 @@ export HOMEverif_global=${HOMEverif_global:-${HOMEgfs}/sorc/verif-global.fd}
export model_list=${model:-$PSLOT}
export model_dir_list=${model_dir:-${NOSCRUB}/archive}
export model_stat_dir_list=${model_stat_dir:-${NOSCRUB}/archive}
export model_file_format_list=${model_file_format:-"pgbf{lead?fmt=%2H}.${CDUMP}.{init?fmt=%Y%m%d%H}.grib2"}
export model_file_format_list=${model_file_format:-"pgbf{lead?fmt=%2H}.${RUN}.{init?fmt=%Y%m%d%H}.grib2"}
export model_hpss_dir_list=${model_hpss_dir:-/NCEPDEV/$HPSS_PROJECT/1year/$USER/$machine/scratch}
export model_data_run_hpss=${get_data_from_hpss:-"NO"}
export hpss_walltime=${hpss_walltime:-10}
Expand Down Expand Up @@ -98,23 +83,23 @@ export SENDDBN_NTC=${SENDDBN_NTC:-"NO"}
# GRID2GRID STEP 1
export g2g1_type_list=${g2g1_type_list:-"anom pres sfc"}
export g2g1_anom_truth_name=${g2g1_anom_truth_name:-"self_anl"}
export g2g1_anom_truth_file_format_list=${g2g1_anom_truth_file_format:-"pgbanl.${CDUMP}.{valid?fmt=%Y%m%d%H}.grib2"}
export g2g1_anom_truth_file_format_list=${g2g1_anom_truth_file_format:-"pgbanl.${RUN}.{valid?fmt=%Y%m%d%H}.grib2"}
export g2g1_anom_fcyc_list=${fcyc_list}
export g2g1_anom_vhr_list=${vhr_list}
export g2g1_anom_fhr_min=${g2g1_anom_fhr_min:-$FHMIN_GFS}
export g2g1_anom_fhr_max=${g2g1_anom_fhr_max:-$FHMAX_GFS}
export g2g1_anom_grid=${g2g1_anom_grid:-"G002"}
export g2g1_anom_gather_by=${g2g1_anom_gather_by:-"VSDB"}
export g2g1_pres_truth_name=${g2g1_pres_truth_name:-"self_anl"}
export g2g1_pres_truth_file_format_list=${g2g1_pres_truth_file_format:-"pgbanl.${CDUMP}.{valid?fmt=%Y%m%d%H}.grib2"}
export g2g1_pres_truth_file_format_list=${g2g1_pres_truth_file_format:-"pgbanl.${RUN}.{valid?fmt=%Y%m%d%H}.grib2"}
export g2g1_pres_fcyc_list=${fcyc_list}
export g2g1_pres_vhr_list=${vhr_list}
export g2g1_pres_fhr_min=${g2g1_pres_fhr_min:-$FHMIN_GFS}
export g2g1_pres_fhr_max=${g2g1_pres_fhr_max:-$FHMAX_GFS}
export g2g1_pres_grid=${g2g1_pres_grid:-"G002"}
export g2g1_pres_gather_by=${g2g1_pres_gather_by:-"VSDB"}
export g2g1_sfc_truth_name=${g2g1_sfc_truth_name:-"self_f00"}
export g2g1_sfc_truth_file_format_list=${g2g1_sfc_truth_file_format:-"pgbf00.${CDUMP}.{valid?fmt=%Y%m%d%H}.grib2"}
export g2g1_sfc_truth_file_format_list=${g2g1_sfc_truth_file_format:-"pgbf00.${RUN}.{valid?fmt=%Y%m%d%H}.grib2"}
export g2g1_sfc_fcyc_list=${fcyc_list}
export g2g1_sfc_vhr_list=${vhr_list}
export g2g1_sfc_fhr_min=${g2g1_sfc_fhr_min:-$FHMIN_GFS}
Expand Down Expand Up @@ -155,7 +140,7 @@ export g2o1_mv_database_desc=${g2o1_mv_database_desc:-"Grid-to-obs METplus data
export precip1_type_list=${precip1_type_list:-"ccpa_accum24hr"}
export precip1_ccpa_accum24hr_model_bucket_list=${precip1_ccpa_accum24hr_model_bucket:-"06"}
export precip1_ccpa_accum24hr_model_var_list=${precip1_ccpa_accum24hr_model_var:-"APCP"}
export precip1_ccpa_accum24hr_model_file_format_list=${precip1_ccpa_accum24hr_model_file_format:-"pgbf{lead?fmt=%2H}.${CDUMP}.{init?fmt=%Y%m%d%H}.grib2"}
export precip1_ccpa_accum24hr_model_file_format_list=${precip1_ccpa_accum24hr_model_file_format:-"pgbf{lead?fmt=%2H}.${RUN}.{init?fmt=%Y%m%d%H}.grib2"}
export precip1_ccpa_accum24hr_fcyc_list=${fcyc_list}
export precip1_ccpa_accum24hr_fhr_min=${precip1_ccpa_accum24hr_fhr_min:-$FHMIN_GFS}
export precip1_ccpa_accum24hr_fhr_max=${precip1_ccpa_accum24hr_fhr_max:-$FHMAX_GFS}
Expand Down