Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modules/FindSphinx.cmake #61

Merged
merged 1 commit into from
May 20, 2022
Merged

Add Modules/FindSphinx.cmake #61

merged 1 commit into from
May 20, 2022

Conversation

climbfuji
Copy link
Collaborator

aerorahul
aerorahul approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
Just out of curiosity, why sphinx-build2 on line 16?

@climbfuji
Copy link
Collaborator Author

looks good.
Just out of curiosity, why sphinx-build2 on line 16?

Good question. Because of this: https://opensource.apple.com/source/clang/clang-700.0.72/src/cmake/modules/FindSphinx.cmake.auto.html

@aerorahul aerorahul merged commit 0e2a038 into NOAA-EMC:develop May 20, 2022
@climbfuji
Copy link
Collaborator Author

Thanks, @aerorahul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@kgerheiser kgerheiser Awaiting requested review from kgerheiser

@edwardhartnett edwardhartnett Awaiting requested review from edwardhartnett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @aerorahul