Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Modules/FindWGRIB2.cmake #41

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Remove Modules/FindWGRIB2.cmake #41

merged 1 commit into from
Aug 10, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 10, 2020 •
edited
Loading

For branch develop. We need to update release/public-v1 afterwards.

As the title says. No longer required, because NCEPLIBS-wgrib2 creates the necessary cmake config files so that the package can be found.

@climbfuji climbfuji changed the base branch from develop to release/public-v1 August 10, 2020 20:09
@climbfuji climbfuji changed the base branch from release/public-v1 to develop August 10, 2020 20:10
@climbfuji
Copy link
Collaborator Author

I tested this with NCEPLIBS-external and NCEPLIBS (release/public-v1) and it works.

@climbfuji climbfuji merged commit 654cc5a into NOAA-EMC:develop Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgerheiser kgerheiser kgerheiser approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @kgerheiser