-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate the eko back to save disk space #117
Conversation
Please, avoid rotating back. Just keep the original one (copy/duplicate it before). Otherwise, you will accumulate more and more numerical error. |
Yes this was exactly my point. However @giacomomagni pointed out that copying 60gb every time (for the jets ekos) is a bit extreme. |
If you do not need the original one, then you can well thrash it, and save space. But if you need it, then instead you should keep. The only case which we can not account for is if you do not have enough space to even perform the operation (copying), and you want to keep the original EKO. |
Maybe we should start rolling out eko v0.14 with NNPDF/eko#295 and specifically NNPDF/eko#292 |
I'm try to see if this temporary 5016b86 solution is doable also for jets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andreab1997 this solves the issue.
I'd be happy to merge.
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
I would be happy to merge as well now. |
We want to rotate the eko back to the usual grid of 50 points to save disk space. In fact, as noticed by @giacomomagni, depending on the dataset, there is a factor up to ~30 in size between the original eko and the eko after the rotation (for the jets dataset the factor is ~24).