-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset variants #494
Comments
Two comments.
|
There is some discussion on this at #226. Since then I have reached the conclusion that we really want two kinds of files:
|
@wilsonmr I guess the above should be added as an objective for reportengine 1.0. |
See #496. |
We have recently been taking the approach of never modifying existing datasets (which I think is a good thing) and instead adding fixed versions of them with different names. For example we have the so called *_SF sets, which stands for "symmetrization fix".
I find this approach to also be problematic. For one I seemed to be the only one at the meeting last week who seemed to know what these things are and that you should use them instead of the default ones. Also, all that might be documented somewhere, but I couldn't find it (admittedly I only spent 30 seconds searching but still).
I think a better approach would be to teach the code to know that there are variants of the various datasets (the variant used in 3.1 the variant that had a bug fixed and so on). And then have ways to warn you if you are using a deprecated variant or to know what the default variants are.
This ties with:
The text was updated successfully, but these errors were encountered: