Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when using deprecated data sets? #1139

Closed
voisey opened this issue Mar 10, 2021 · 1 comment
Closed

Warnings when using deprecated data sets? #1139

voisey opened this issue Mar 10, 2021 · 1 comment

Comments

@voisey
Copy link
Contributor

voisey commented Mar 10, 2021

When a dataset is updated/fixed for some reason, like was done with CDFZRAP (#1068), we tend to keep the old dataset and create a dataset with a new name for the new version, e.g. we now have CDFZRAP and CDFZRAP_NEW. This makes sense for reproducibility of old results, but I suppose there's nothing to stop someone unintentionally using the old version. I was therefore thinking that we could perhaps add some warnings to the code when such datasets are used? I'm not sure how comprehensive these warnings could/should be, but the obvious place would be in vp-setupfit. Just something like "CDFZRAP is a deprecated dataset, which exists for reproducibility. The up-to-date version is CDFZRAP_NEW". Thoughts?

@Zaharid
Copy link
Contributor

Zaharid commented Mar 10, 2021

I thing we should go for the real solution to the problem, namely #494.

@voisey voisey closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants