Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NetworkTarget to its own nuget-package #5636

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 6, 2024

Crude move of everything related to NetworkTarget. Resolves #2680

Might want to look at changing Log4jXml-Layout to be based on NLog XmlLayout. And GelfLayout based on NLog JsonLayout. And SyslogLayout based on CompoundLayout.

@snakefoot snakefoot added the breaking change Breaking API change (different to semantic change) label Oct 6, 2024
@snakefoot snakefoot added this to the 6.0 milestone Oct 6, 2024
@snakefoot snakefoot force-pushed the networktarget branch 2 times, most recently from 4e665c3 to 633a4ad Compare October 6, 2024 18:55
Copy link

sonarqubecloud bot commented Oct 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking API change (different to semantic change) size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move NetworkTarget to NLog.NetworkTarget package
1 participant