ASPNETCORE_ENVIRONMENT takes now precedence over DOTNET_ENVIRONMENT #614
Conversation
|
Maybe Azure Pipelines Config must be changed to use Nuget 5.8.0 ? |
|
Close and re-open to trigger rebuild |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I think this small behavior change needs a minor version bump. Im not 100% sure this is a bug and afraid of the "hidden" change. |
|
It would be nice if we could unit test this. :) |
Not sure how to perform mocking with extension-methods. |
|
A yes good one. You can't mock extensions (as it's syntactic sugar), the underlying calls should be mocked for that |
|
Guess one could make an internal extension-method that requires an interface-parameter which is used.
…Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
A yes good one. You can't mock extensions (as it's syntactic sugar), the underlying calls should be mocked for that
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#614 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACXZ7HC6ZLGHHKCUQZ25BYTSXCEITANCNFSM4UYXG2IA>.
|
|
I've created a new PR for the license, as we needed that also for other repos and thats easier to track (now and in the futher) |
304NotModified
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
you're right about the mocking. Environment.GetEnvironmentVariable can't be mocked easily, and if we do, we still can't assert something good as LoadConfigurationFromFile could not be tested easily. To for now we keep it like this |
See also: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/environments?view=aspnetcore-5.0#environments