Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IHostingEnvironment is obsolete in NetCore3. Instead use ILoggingBuilder.ConfigureNLog #478

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

snakefoot
Copy link
Contributor

No description provided.

@snakefoot
Copy link
Contributor Author

snakefoot commented Sep 24, 2019

Maybe wait for NLog.Extension.Logging ver. 1.6.0 to be released, before releasing NLog.Web.AspNetCore 4.9. Then dependency can be included.

@304NotModified
Copy link
Member

Yes was also thinking about that :)

@304NotModified 304NotModified merged commit fa802de into NLog:dev Sep 24, 2019
@snakefoot
Copy link
Contributor Author

Forgot to remove obsolete-attributes from the ILoggerBuilder-extension-methods. Created PR #482

@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 2 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions enhancement size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants