Removed obsolete-attribute from ConfigureNLog-methods for ILoggingBui…

…lder. No longer generates double logging.
NLog · Sep 24, 2019 · 951d3a2 · 951d3a2
1 parent fa802de
commit 951d3a2
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/NLog.Web.AspNetCore/AspNetExtensions.cs b/src/NLog.Web.AspNetCore/AspNetExtensions.cs
@@ -80,11 +80,9 @@ public static IServiceProvider SetupNLogServiceLocator(this IServiceProvider ser
         /// <param name="configFileName">Path to NLog configuration file, e.g. nlog.config. </param>
         /// >
         /// <returns>LogFactory to get loggers, add events etc</returns>
-        [Obsolete("Use UseNLog() on IWebHostBuilder, and NLog.Web.NLogBuilder.ConfigureNLog()")]
         public static LogFactory ConfigureNLog(this ILoggingBuilder builder, string configFileName)
         {
-            ConfigurationItemFactory.Default.RegisterItemsFromAssembly(typeof(AspNetExtensions).GetTypeInfo().Assembly);
-            builder.AddNLog();
+            ConfigureServicesNLog(null, builder.Services, serviceProvider => serviceProvider.GetService<IConfiguration>());
             return LogManager.LoadConfiguration(configFileName);
         }
 
@@ -96,11 +94,9 @@ public static LogFactory ConfigureNLog(this ILoggingBuilder builder, string conf
         /// <param name="builder">The logging builder</param>
         /// <param name="configuration">Config for NLog</param>
         /// <returns>LogFactory to get loggers, add events etc</returns>
-        [Obsolete("Use UseNLog() on IWebHostBuilder, and NLog.Web.NLogBuilder.ConfigureNLog()")]
         public static LogFactory ConfigureNLog(this ILoggingBuilder builder, LoggingConfiguration configuration)
         {
-            ConfigurationItemFactory.Default.RegisterItemsFromAssembly(typeof(AspNetExtensions).GetTypeInfo().Assembly);
-            builder.AddNLog();
+            ConfigureServicesNLog(null, builder.Services, serviceProvider => serviceProvider.GetService<IConfiguration>());
             LogManager.Configuration = configuration;
             return LogManager.LogFactory;
         }