Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLogger - Faster checking if LogLevel IsEnabled #509

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jun 6, 2021

When using NLogProviderOptions.RemoveLoggerFactoryFilter = true, then Microsoft LoggerFactory will arrive with all LogEvents on all LogLevels (No longer "protected" by Microsoft LoggerFactory own Filtering-logic)

Reduced to single switch from Microsoft LogLevel to NLog Logger-IsEnabled. For faster discarding of Debug / Trace-events.

Instead of making 2 switches:

  • Microsoft LogLevel -> NLog LogLevel
  • NLog LogLevel -> NLog Logger-IsEnabled.

@snakefoot snakefoot added this to the 1.7.3 milestone Jun 6, 2021
@snakefoot snakefoot enabled auto-merge (squash) June 6, 2021 11:13
@snakefoot snakefoot merged commit c17101e into NLog:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant