Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicrosoftConsoleLayoutRenderer - For Hosting Lifetime Startup Messages #490

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 21, 2021

Resolves #489 so you can do this:

<nlog>
  <targets>
    <target name="lifetimeConsole" xsi:type="Console" layout="${MicrosoftConsoleLayout}"  />
  </targets>
  <rules>
     <logger name="Microsoft.Hosting.Lifetime" level="Info" writeTo="lifetimeConsole" final="true" /> 
  </rules>
</nlog>

@snakefoot snakefoot added this to the 1.7.2 milestone Mar 21, 2021
@snakefoot snakefoot merged commit 5d91b3e into NLog:master Mar 24, 2021
@304NotModified
Copy link
Member

@snakefoot

I was checking the code coverage, then I saw line 32. I that correct? Why do we parse the int, but don't use the value? Not sure if that can be right

image

@snakefoot
Copy link
Contributor Author

snakefoot commented Mar 26, 2021

If EventId_Id was a string then it would parse and use the int-value. But I guess this int.TryParsefallback is rather unnecessary.

@snakefoot
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce MicrosoftConsoleLayoutRenderer
2 participants