Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced SetupExtensionLogging extension method for LogFactory.Setup #410

Merged

Conversation

snakefoot
Copy link
Contributor

Example of how it is used:

                LogManager.Setup()
                    .SetupExtensions(s => s.AutoLoadAssemblies(false))
                    .SetupExtensionLogging(s => s.LoadNLogLoggingConfiguration(config));

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #410 into master will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   82.08%   82.45%   +0.36%     
==========================================
  Files          12       14       +2     
  Lines        1178     1197      +19     
  Branches      194      194              
==========================================
+ Hits          967      987      +20     
  Misses        141      141              
+ Partials       70       69       -1     
Impacted Files Coverage Δ
...xtensions.Logging/Config/SetupBuilderExtensions.cs 100.00% <100.00%> (ø)
...ing/Config/SetupLoggerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ensions.Logging/Config/NLogLoggingConfiguration.cs 92.45% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea6e0a...628f1d5. Read the comment docs.

@304NotModified 304NotModified merged commit 4db9fc3 into NLog:master Mar 18, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request Mar 31, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request Mar 31, 2020
304NotModified pushed a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants