Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILoggerFactory is obsolete in .NET Core 3. Instead use ILoggingBuilder.AddNLog #342

Merged
merged 4 commits into from
Sep 24, 2019
Merged

ILoggerFactory is obsolete in .NET Core 3. Instead use ILoggingBuilder.AddNLog #342

merged 4 commits into from
Sep 24, 2019

Conversation

snakefoot
Copy link
Contributor

or IHostBuilder.UseNLog()

@codecov-io
Copy link

codecov-io commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files          12       12           
  Lines        1104     1104           
  Branches      193      193           
=======================================
  Hits          904      904           
  Misses        136      136           
  Partials       64       64
Impacted Files Coverage Δ
...tensions.Logging/Extensions/ConfigureExtensions.cs 31.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d3410...432e94c. Read the comment docs.

@snakefoot snakefoot mentioned this pull request Sep 24, 2019
Closed
@304NotModified 304NotModified added this to the 1.5.5 milestone Sep 24, 2019
@304NotModified 304NotModified self-requested a review September 24, 2019 19:22
304NotModified
304NotModified approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: adding obsoletes needs a minor version number update, so 1.6

@snakefoot
Copy link
Contributor Author

PS: adding obsoletes needs a minor version number update, so 1.6

Added commit to update to version 1.6. Careful merging will publish new version.

@304NotModified 304NotModified changed the title ILoggerFactory is obsolete in NetCore3. Instead use ILoggingBuilder.AddNLog ILoggerFactory is obsolete in .NET Core 3. Instead use ILoggingBuilder.AddNLog Sep 24, 2019
@304NotModified 304NotModified merged commit b3df47c into NLog:master Sep 24, 2019
@304NotModified
Copy link
Member

oops almost released 1.6. Canceled the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@snakefoot @codecov-io @304NotModified