Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Core 3.0, remove Travis integration #332

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Conversation

304NotModified
Copy link
Member

No description provided.

@304NotModified
Copy link
Member Author

Dunno if recommend to target netcore 3

@304NotModified
Copy link
Member Author

304NotModified commented Sep 11, 2019

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files          12       12           
  Lines        1127     1127           
  Branches      194      194           
=======================================
  Hits          920      920           
  Misses        140      140           
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4d720...4d078e3. Read the comment docs.

@304NotModified
Copy link
Member Author

@snakefoot
While I dislike building for an platform (netcore 3) and not netstandard, I think we should include this, otherwise an user could have dependency problems with .net core 3 (this one build Microsoft.Extensions.Logging v2 and using v3)

Do you agree?

@304NotModified
Copy link
Member Author

(have to find how to fix Travis)

@snakefoot
Copy link
Contributor

@304NotModified While I dislike building for an platform (netcore 3) and not netstandard, I think we should include this.

Think it is a good idea. Was considering netstandard2.1 but this is also supported by NetCore21, so it cannot be used as an option.

@snakefoot
Copy link
Contributor

But please also update NLog.Extension.Hosting.

@snakefoot
Copy link
Contributor

Guess the same operation is also needed on NLog.Web.AspNetCore 4.9

@304NotModified
Copy link
Member Author

But please also update NLog.Extension.Hosting.

done, not tested yet locally (slow internet and VS needs an update)

@304NotModified
Copy link
Member Author

Guess the same operation is also needed on NLog.Web.AspNetCore 4.9

I think also indeed

@304NotModified 304NotModified changed the title (tryout/WIP) Support .NET Core 3.0 Support .NET Core 3.0 Sep 24, 2019
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 24, 2019
@304NotModified
Copy link
Member Author

@304NotModified 304NotModified added this to the 1.6 milestone Sep 24, 2019
@jenscski
Copy link

jenscski commented Oct 2, 2019

@304NotModified While I dislike building for an platform (netcore 3) and not netstandard, I think we should include this.

Think it is a good idea. Was considering netstandard2.1 but this is also supported by NetCore21, so it cannot be used as an option.

NetCore21 does not support netstandard2.1, you need NetCore30 (https://github.com/dotnet/standard/blob/master/docs/versions/netstandard2.1.md), or am I lost here?

@snakefoot
Copy link
Contributor

snakefoot commented Oct 2, 2019 via email

@304NotModified
Copy link
Member Author

Yes, but the Ms extensions packages target explicit netcore3 and not netstandard2.1. Dunno why exactly

@snakefoot
Copy link
Contributor

snakefoot commented Oct 2, 2019

Yes, but the Ms extensions packages target explicit netcore3 and not netstandard2.1. Dunno why exactly

Yes that is a little weird. Maybe it is to better handle netcore3 and netcore31 for the same nuget-package. But didn't think netcore2 and netcore21 and netcore22 was a problem.

@304NotModified
Copy link
Member Author

I gonna ignore Travis for a while.. maybe will remove the integration.

@304NotModified
Copy link
Member Author

@304NotModified 304NotModified changed the title Support .NET Core 3.0 Support .NET Core 3.0, remove Travis integration Oct 2, 2019
@304NotModified 304NotModified merged commit ad799d2 into master Oct 2, 2019
@304NotModified 304NotModified deleted the netcore3 branch October 2, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants