-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .NET Core 3.0, remove Travis integration #332
Conversation
1cd0fa1
to
29f1b9b
Compare
Dunno if recommend to target netcore 3 |
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 12 12
Lines 1127 1127
Branches 194 194
=======================================
Hits 920 920
Misses 140 140
Partials 67 67 Continue to review full report at Codecov.
|
@snakefoot Do you agree? |
(have to find how to fix Travis) |
Think it is a good idea. Was considering netstandard2.1 but this is also supported by NetCore21, so it cannot be used as an option. |
But please also update NLog.Extension.Hosting. |
Guess the same operation is also needed on NLog.Web.AspNetCore 4.9 |
done, not tested yet locally (slow internet and VS needs an update) |
I think also indeed |
NetCore21 does not support netstandard2.1, you need NetCore30 (https://github.com/dotnet/standard/blob/master/docs/versions/netstandard2.1.md), or am I lost here? |
You are right. Netstandard 2.1 will not be supported by NetCore 2.1 and NetCore 2.2
Very certain that I read something else just a moment ago, but cannot find it.
I think we should go for netstandard2.1 instead of netcore3 then Travis should also build "netstandard2.1" using NetCore3-preview
|
Yes, but the Ms extensions packages target explicit netcore3 and not netstandard2.1. Dunno why exactly |
Yes that is a little weird. Maybe it is to better handle netcore3 and netcore31 for the same nuget-package. But didn't think netcore2 and netcore21 and netcore22 was a problem. |
c9e2b34
to
d849c31
Compare
I gonna ignore Travis for a while.. maybe will remove the integration. |
5fe2664
to
4d078e3
Compare
No description provided.