Handle IndexOutOfRangeException thrown by Microsoft.Extensions.Logging when using invalid format string

[snakefoot]

Throw FormatException when IndexOutOfRangeException caused by invalid parameters

See also #271

[codecov]

Codecov Report

Merging #272 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   69.38%   69.58%   +0.19%     
==========================================
  Files           9        9              
  Lines         761      766       +5     
  Branches      135      135              
==========================================
+ Hits          528      533       +5     
  Misses        180      180              
  Partials       53       53

Impacted Files	Coverage Δ
...nsions.Logging/Logging/NLogMessageParameterList.cs	73.88% <100%> (+1.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380305c...4d5a7cb. Read the comment docs.

[304NotModified]

Thanks! But I think we should report this bug at Ms, and hope those guys fix it?

[snakefoot]

Even if they decide to fix the "bug" (garbage-in means garbage out) then it will not be fixed for any known version of NetCore ("bug" not important enough to be back-ported). See also:

dotnet/extensions#550
dotnet/extensions#664
https://github.com/aspnet/Extensions/issues/668

So I think this fix should be made, as all MEL-Loggers are expected to throw FormatException (signals error in format-string) and not IndexOutOfRangeException (signals error in NLog)

[304NotModified]

Even if they decide to fix the "bug" (garbage-in means garbage out) then it will not be fixed for any known version of NetCore ("bug" not important enough to be back-ported). See also:

aspnet/Extensions#550
aspnet/Extensions#664
aspnet/Extensions#668

So I think this fix should be made, as all MEL-Loggers are expected to throw FormatException (signals error in format-string) and not IndexOutOfRangeException (signals error in NLog)

You convinced me, thanks for the effort :

[304NotModified]

Thanks!!