Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional rr types #246

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Additional rr types #246

merged 14 commits into from
Jan 23, 2025

Conversation

wtoorop
Copy link
Member

@wtoorop wtoorop commented Dec 30, 2024

Support for EID, NIMLOC, SINK, TALINK, DSYNC, DOA, AMTRELAY and IPN RR types.

wtoorop and others added 6 commits January 21, 2025 10:33
AMTRELAY and IPN are now also supported
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
@wtoorop wtoorop marked this pull request as ready for review January 22, 2025 12:17
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really nice to have a more comprehensive support for RR types! The code looks fair, the complication of the parser makes it way into the new parsed field types.

@wtoorop wtoorop merged commit 80f5f44 into main Jan 23, 2025
11 checks passed
@wtoorop wtoorop deleted the additional-rr-types branch January 23, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants