domain-resolv: allow a different canonical name in FoundHostsIter #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vavrusa
force-pushed
the
marek/resolv-independent-cnames
branch
2 times, most recently
from
95a7748 to
267df42
Compare
|
Thank you for the PR! As the CI failure is mostly related to newly introduced Clippy lints, could you merge master into your branch to get it to “green” before merging? Fixes for them should be in master now. |
|
Yes of course, happy to get to work on domain again! |
Each message may resolve to a different canonical name, so calculating it only from the first response might cause records to be ignored in the second response.
vavrusa
force-pushed
the
marek/resolv-independent-cnames
branch
from
267df42 to
92be6e3
Compare
|
Thanks! Are you planning to tag a release any time soon, or should I keep using the revision for now? |
|
I was planning on doing a release today but then caught up in cleaning up the documentation. Expect 0.6.0 on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each message may resolve to a different canonical name, so calculating it
only from the first response might cause records to be ignored in the second
response.