base/message_builder: add missing OptBuilder methods #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed with clippy errors unrelated to this PR, do you want me to fix those here? |
|
I know it is a tiny thing, but could you move the ring update to a separate PR? I’ll fix the Clippy complaint without a PR directly in master. |
|
No problem! I removed the commit and will open a separate PR after this. |
This allows OptBuilder to set DO flag and change EDNS version.
|
Should I bump the release version or are you going to do it separately? |
|
Oh, darn. I must have missed the notification for your update. Merging now. Sorry. |
|
I’ll do the ring update. |
|
Actually, your commit for that disappeared – which version did you want for ring? |
|
No problem! I repushed it in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows OptBuilder to set DO flag and change EDNS version.