Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSSEC validator #328

Merged
merged 92 commits into from
Jun 13, 2024
Merged

DNSSEC validator #328

merged 92 commits into from
Jun 13, 2024

Conversation

Philip-NLnetLabs
Copy link
Member

The documentation needs a bit more. A few minor things that are still needed: the GetResult future in the validator transport is not cancel safe. Too large TTLs need to be capped.

Philip-NLnetLabs and others added 22 commits June 6, 2024 14:27
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
#![cfg(feature = "unstable-validator")]

//! This module provides a DNSSEC validator as described in RFCs
//! [4033](https://www.rfc-editor.org/info/rfc4033),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently talked about this with Martin and we converged on referencing tools.ietf.org for RFCs instead. Do you agree?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't you mean tools.ietf.org. That doesn't work. Maybe you mean the datatracker? In any case I use what is used in the bibtex files. Those links seem the best for stable references.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t feel too strongly about which one we use, but we should be consistent.

But in any case, https://www.rfc-editor.org/info/rfc4033 is kind of terrible since you need an extra click to get to the text. If we use the RFC Editor site, it should probably be https://www.rfc-editor.org/rfc/rfc4033.html (i.e., rfc instead of info).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the guide for references in RFCs: https://authors.ietf.org/en/references-in-rfcxml

@partim partim merged commit 97bfa2c into main Jun 13, 2024
24 checks passed
@Philip-NLnetLabs Philip-NLnetLabs deleted the validator branch October 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants