Domain name compression is broken in 0.10.0 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see |
The `Iterator` implementation on SliceLabelsIter was not advancing offset with the a leading length octet.
Add a test case where owner name in the A record is compressed.
hunts
force-pushed
the
fix-name-compression
branch
from
7b64a96 to
44f4218
Compare
|
Thank you for the PR! This actually used to use |
partim
approved these changes
May 30, 2024
partim
added a commit
that referenced
this pull request
Jun 3, 2024
New * Allow AllRecordData’s parsing impls to accept an unsized [u8] as the source octets. ([#310] by [@xofyarg]) * Made `sign::records::FamilyName` public. ([#312] by [@achow101]) * Added an impl of `FromStr` for `Question`. ([#317]) Bug fixes * Accept an empty record type bitmap when scanning NSEC/NSEC3 data. ([#310] by [@xofyarg]) * Fix serialization of ProtoRrsig to conform with RFC 4034. ([#313 by [@achow101]) * Add `?Sized` bounds to `Message::is_answer` and `ParsedRecord::to_record`. ([#318] by [@xofyarg], [#325] by [@hunts]) * Bring back `MessageBuilder::as_target`. ([#318] by [@xofyarg]) * Bring back `impl FreezeBuilder for StaticCompressor`. ([#318] by [@xofyarg]) * `sign::records::RecordsIter::skip_before` now stops at the first name in zone even if the apex itself doesn’t appear. ([#314] by [@achow101]) * Fix a counting error in `SliceLabelsIter::next` that broke compression via `StaticCompressor`. ([#321] by [@hunts]) Unstable features * New unstable feature `unstable-stelline` for the Stelline testing framework as a “normal” module of _domain._ ([#315]) * Renamed the domain name types in `zonetree` from `Dname` to `Name`. ([#308]) Other changes * The minimum Rust version is now 1.78. ([#320])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
SliceLabelsIter'snext()implement that is causing it not able to return the full/right labels in the octets slice.StaticCompressorleveragesSliceLabelsIterto search known domain names in the underlying octets, is not able to find existing names because of this. Thus, leading to broken domain name compression in 0.10.0.