Fix BMPString universal class; Add missing ASN.1 tags (14, 30-36) #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag::BMP_STRING
is incorrectly assigned the classUNIVERSAL 29
instead ofUNIVERSAL 30
1. Additionally, a number of universal class tag assignments are missing intag.rs
. This commit fixes addresses both of these issues alongside a few minor nitpicks.All changes are to
tag.rs
:UNIVERSAL 30
toTag::BMP_STRING
(BMPString
)1UNIVERSAL 29
to missing ASN.1 tagTag::CHARACTER_STRING
(CHARACTER STRING
)2Tag::TIME
(TIME
,UNIVERSAL 14
)3Tag::DATE
(DATE
,UNIVERSAL 31
)34Tag::TIME_OF_DAY
(TIME-OF-DAY
UNIVERSAL 32
)34Tag::DATE_TIME
(DATE-TIME
,UNIVERSAL 33
)34Tag::DURATION
(DURATION
,UNIVERSAL 34
)34Tag::OID_IRI
(OID-IRI
,UNIVERSAL 35
)35Tag::RELATIVE_OID_IRI
(RELATIVE-OID-IRI
,UNIVERSAL 36
)36UNIVERAL
➡️UNIVERSAL
) forENUMERATED
,EMBEDDED_PDV
,RELATIVE_OID
andGENERALIZED_TIME
LAST_OCTET_MASK
Thank you for
bcder
!Footnotes
ITU-T X.680 (02/2021) Table 8 – List of restricted character string types ↩ ↩2
ITU-T X.680 (02/2021) 44 Definition of unrestricted character string types ↩
ITU-T X.680 (02/2021) Table 1 – Universal class tag assignments ↩ ↩2 ↩3 ↩4 ↩5 ↩6 ↩7
ITU-T X.680 (02/2021) 38.4 Useful time types ↩ ↩2 ↩3 ↩4
ITU-T X.680 (02/2021) 34 Notation for the OID internationalized resource identifier type ↩
ITU-T X.680 (02/2021) 35 Notation for the relative OID internationalized resource identifier type ↩