Support creation of arbitrary length Unsigned BER integers from given bytes. #59
Conversation
There was a problem hiding this comment.
To be consistent, the function should probably be named from_slice. I am trying to avoid the term bytes for anything that isn’t actually a bytes::Bytes (hence the use of octets instead of bytes). I don’t think it needs to be generic over AsRef<[u8]> – in fact, because you are copying, it might be better not to be.
I think I also would want to it return an error for a wrongly formatted slice. You need to do the check anyway, might as well error out if things go wrong.
Finally, since we are using bytes::Bytes all over the place, a function from_bytes would be nice that only copies if absolutely necessary (i.e., if it needs to stick a zero octet in front). Perhaps you somehow can use the testing logic for both functions?
|
(I fixed the Clippy errors in main, so if you merge main, the CI errors should go away.) |
No description provided.