Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes 0.5 compat #43

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

Fabian-Gruenbichler
Copy link
Contributor

captured.rs is still broken, see #42

Signed-off-by: Fabian Grünbichler fabian.gruenbichler@student.tuwien.ac.at

@partim
Copy link
Member

partim commented Feb 10, 2020

Thanks for the PR!

I’d like to do one more release in the current 0.4 series with #44, and then we can move to 0.5 with bytes 0.5.

src/encode/primitive.rs Outdated Show resolved Hide resolved
@partim partim marked this pull request as ready for review March 4, 2020 13:43
@partim
Copy link
Member

partim commented Mar 4, 2020

I created a CaptureBuilder to deal with the Bytes::extend_by_slice issue. Can you maybe merge master into your branch? We should be good to go then.

Signed-off-by: Fabian Grünbichler <fabian.gruenbichler@student.tuwien.ac.at>
@Fabian-Gruenbichler Fabian-Gruenbichler changed the title WIP: bytes 0.5 compat bytes 0.5 compat Mar 5, 2020
@Fabian-Gruenbichler
Copy link
Contributor Author

done (rebased on current master), build and test runs through locally - let's see what CI has to say ;)

@partim
Copy link
Member

partim commented Mar 5, 2020

I sneakily moved to Github Actions in master and voila: all good.

Thanks for doing this work!

@partim partim merged commit f8bac19 into NLnetLabs:master Mar 5, 2020
@partim partim mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants