Replaced @DirtiesContext with manual reset of H2 database #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoRosendo
force-pushed
the
feature/test-database-reset
branch
2 times, most recently
from
3aecafa to
b951d94
Compare
DoStini
reviewed
Feb 2, 2023
|
|
||
| override fun beforeTestMethod(testContext: TestContext) { | ||
| super.beforeTestMethod(testContext) | ||
| println("Cleaning up database...") |
There was a problem hiding this comment.
Does this show up in the test log?
There was a problem hiding this comment.
Should I change anything or can we merge? This is an important PR @DoStini
There was a problem hiding this comment.
Sorry for the delay, it might be a bit cluttered but we can merge
BrunoRosendo
force-pushed
the
feature/test-database-reset
branch
from
b951d94 to
5263529
Compare
DoStini
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
@DirtiesContextlogic kept bringing issues in the tests, I replaced it with a listener that automatically truncates every table from the H2 test database. Additionally, I had to deactivate an optimization on the entity manager to ensure ID consistency.Here are the 2 primary sources that inspired this implementation:
This means that the DB will be reset in EVERY single test, as opposed to only between endpoint tests like before. There was no need for an
@EndpointTestin this implementation since it's the same as the@NestedTest, so I removed it.Review checklist
docs/openapi.yml