Models and endpoints for user accounts #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoRosendo
force-pushed
the
feature/userAccounts
branch
from
1ed3dee to
f375df2
Compare
BrunoRosendo
commented
Nov 8, 2022
Comment on lines
+54
to
+55
| @JoinColumn | ||
| @OneToMany(cascade = [CascadeType.ALL], fetch = FetchType.EAGER) |
There was a problem hiding this comment.
Details about these annotations' behaviour can be found at:
https://stackoverflow.com/questions/52887653/onetomany-relationship-does-not-save-the-primary-key-of-the-parent-in-the-child
https://stackoverflow.com/questions/2990799/difference-between-fetchtype-lazy-and-eager-in-java-persistence-api
|
This PR is only missing tests now |
ruialves35
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
Currently missing tests and a fix regarding relationship between Account and CustomWebsite
Review checklist
docs/openapi.yml