Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use <nz-icon> to instead of [nz-icon] #8927

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Dec 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

将所有 [nz-icon] 替换为推荐的 <nz-icon> 写法。

如果用户在 CSS 中使用了 [nz-icon] 属性选择器去选择 zorro 组件内部的 icon,则需要更新为使用元素选择器。

组件内部的 DOM 结构通常不是 public 的,这属于 breaking changes 吗?

如果属于 breaking changes,那么应该也可以进入 beta 版本中。

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Dec 12, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (2e0c78d) to head (46a01ab).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8927      +/-   ##
==========================================
+ Coverage   91.91%   91.93%   +0.01%     
==========================================
  Files         554      554              
  Lines       19682    19680       -2     
  Branches     2936     2936              
==========================================
+ Hits        18091    18092       +1     
+ Misses       1265     1263       -2     
+ Partials      326      325       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery
Copy link
Collaborator

Laffery commented Dec 13, 2024

我认为属于 breaking changes,事实上 19.0.0-beta.0 中我们已经在一些组件中将 [nz-icon] 改成了 <nz-icon>,已经可能会导致用户原来 css 中的选择器失效。
所以我觉得我们不妨在这个 major 版本一次性做完,并且在 release note 中声明后续组件内部都会采用 <nz-icon> 写法,如果需要选择内部元素请更新为新选择器。用户组件自行根据偏好管理

@HyperLife1119 HyperLife1119 added the 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes label Dec 13, 2024
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added this to the v19 milestone Dec 14, 2024
@Laffery Laffery merged commit 8e797c2 into NG-ZORRO:master Dec 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: reviewed-approved PR: target-major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants