feat(module:autocomplete): support standalone component #8193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8193 +/- ##
=======================================
Coverage 91.70% 91.71%
=======================================
Files 519 520 +1
Lines 17887 17905 +18
Branches 2836 2839 +3
=======================================
+ Hits 16403 16421 +18
+ Misses 1182 1181 -1
- Partials 302 303 +1 ☔ View full report in Codecov by Sentry. |
Nicoss54
requested changes
Dec 4, 2023
| @@ -64,6 +65,8 @@ function normalizeDataSource(value: AutocompleteDataSource): AutocompleteDataSou | |||
| preserveWhitespaces: false, | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| encapsulation: ViewEncapsulation.None, | |||
| standalone: true, | |||
| imports: [BidiModule, NgClass, NgFor, NgStyle, NgTemplateOutlet, NzAutocompleteOptionComponent, NzNoAnimationModule], | |||
There was a problem hiding this comment.
suggestion: BidiModule is not necessary here. We don't use dir directive
|
@evgeniyefimov could you juste remove the BidiModule, after that LGTM and i will merge it |
Nicoss54
added
PR: reviewed-changes-requested
PR: partially-approved
Component: AutoComplete
and removed
PR: reviewed-approved
labels
Nicoss54
added
PR: reviewed-approved
and removed
PR: reviewed-changes-requested
PR: partially-approved
labels
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Transfromed Autocomplete module to standalone simillar to #8037
Seems
NzInputModuleis unused. Didn't find any usage of this module in the scope of Autocomplete. Removed.Imported only required directives from @angular/common instead of whole CommonModule.