Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): 修复中文搜索时搜索框展示异常 #8139

Closed
wants to merge 4 commits into from

Conversation

EnochGao
Copy link
Contributor

No description provided.

@zorro-bot
Copy link

zorro-bot bot commented Oct 26, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c0dd00) 91.72% compared to head (2d989a6) 91.72%.

Files Patch % Lines
components/tree-select/tree-select.component.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8139   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         520      520           
  Lines       18010    18016    +6     
  Branches     2838     2838           
=======================================
+ Hits        16519    16526    +7     
+ Misses       1188     1187    -1     
  Partials      303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EnochGao EnochGao changed the title fix(module:tree-select): 解决中文搜索异常 fix(module:tree-select): 修复中文搜索时搜索框展示异常 Oct 26, 2023
@simplejason
Copy link
Member

This code is causing a drop in tree-select performance, and we need to reevaluate the reasons why

@EnochGao
Copy link
Contributor Author

EnochGao commented Dec 1, 2023

改了一下实现,麻烦看一下,能否优先解决,这bug会在中文搜索时,用户体验不好

@EnochGao
Copy link
Contributor Author

EnochGao commented Dec 1, 2023

This code is causing a drop in tree-select performance, and we need to reevaluate the reasons why

I have changed the implementation, please kindly check and see if you can solve it first. This bug will cause bad user experience when searching in Chinese.

@791045873
Copy link

我在antd16上也遇到了这个问题,但是在antd15上是没有问题的。

@791045873
Copy link

@EnochGao 再处理一下啊。有代码检查没通过。

@mufeng510
Copy link

问题依旧存在,能否处理一下

@EnochGao
Copy link
Contributor Author

这个问题移到 #8324 解决了

@EnochGao EnochGao closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants