Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): click outside not change value #6596

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Apr 13, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6595

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 13, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #6596 (a62ae0e) into master (825925c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a62ae0e differs from pull request most recent head 0bafcf1. Consider uploading reports for the commit 0bafcf1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6596   +/-   ##
=======================================
  Coverage   89.92%   89.93%           
=======================================
  Files         481      481           
  Lines       15380    15379    -1     
  Branches     2344     2344           
=======================================
  Hits        13831    13831           
- Misses        929      931    +2     
+ Partials      620      617    -3     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 93.37% <100.00%> (-0.13%) ⬇️
components/date-picker/picker.component.ts 91.76% <100.00%> (+1.82%) ⬆️
components/image/image.directive.ts 89.39% <100.00%> (+0.16%) ⬆️
components/upload/upload-list.component.ts 95.86% <100.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts 89.78% <0.00%> (-1.62%) ⬇️
...ponents/time-picker/time-picker-panel.component.ts 89.11% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825925c...0bafcf1. Read the comment docs.

@wenqi73 wenqi73 force-pushed the dp-click branch 3 times, most recently from 097ae18 to b007b55 Compare April 14, 2021 05:25
@wenqi73 wenqi73 merged commit 62e4bb6 into NG-ZORRO:master Apr 14, 2021
@wenqi73 wenqi73 deleted the dp-click branch April 14, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant