Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix single selection choice content display issues #3802

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

hungtcs
Copy link
Contributor

@hungtcs hungtcs commented Jul 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3710

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #3802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3802   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         706      706           
  Lines       14558    14558           
  Branches     1923     1923           
=======================================
  Hits        13882    13882           
  Misses        246      246           
  Partials      430      430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1e09c...fac69ec. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your pr!
all index.less in style folder are synced from antd react version, we should not change it

@hungtcs
Copy link
Contributor Author

hungtcs commented Jul 16, 2019

@vthinkxie It looks like that the html template for angular is different from react:

<!-- Angular -->
<div class="ant-select-selection-selected-value" style="display: block; opacity: 1;">
  <div class="ant-select-selection__choice__content ">the long text content</div>
</div>
<!-- React -->
<div class="ant-select-selection-selected-value" style="display: block; opacity: 1;">the long text content</div>

@netlify
Copy link

netlify bot commented Jul 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit fac69ec

https://deploy-preview-3802--ng-zorro-master.netlify.com

@wzhudev wzhudev requested a review from vthinkxie July 16, 2019 08:08
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 4dd93e6 into NG-ZORRO:master Jul 16, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants