-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): fix single selection choice content display issues #3802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3802 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 706 706
Lines 14558 14558
Branches 1923 1923
=======================================
Hits 13882 13882
Misses 246 246
Partials 430 430 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your pr!
all index.less in style folder are synced from antd react version, we should not change it
@vthinkxie It looks like that the html template for angular is different from react: <!-- Angular -->
<div class="ant-select-selection-selected-value" style="display: block; opacity: 1;">
<div class="ant-select-selection__choice__content ">the long text content</div>
</div>
<!-- React -->
<div class="ant-select-selection-selected-value" style="display: block; opacity: 1;">the long text content</div> |
Deploy preview for ng-zorro-master ready! Built with commit fac69ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3710
What is the new behavior?
Does this PR introduce a breaking change?
Other information