Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): fix ng-content [nzAddOnBeforeIcon] content projection #3597

Merged
merged 1 commit into from
Jun 21, 2019
Merged

fix(module:input): fix ng-content [nzAddOnBeforeIcon] content projection #3597

merged 1 commit into from
Jun 21, 2019

Conversation

CygnusRoboticus
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Projected content inside of an <nz-input-group> disappears when [nzAddOnBeforeIcon] is updated.

Issue Number: #3596

What is the new behavior?

Projected content is displayed, [nzAddOnBeforeIcon] behaves correctly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I attempted to add tests, but I find angular testing difficult and could not come up with something satisfactory for projected content.

@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 851c32b

https://deploy-preview-3597--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #3597 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3597      +/-   ##
==========================================
+ Coverage   95.72%   95.73%   +<.01%     
==========================================
  Files         690      690              
  Lines       13708    13708              
  Branches     1824     1824              
==========================================
+ Hits        13122    13123       +1     
  Misses        198      198              
+ Partials      388      387       -1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b5d35...851c32b. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit a37ec0a into NG-ZORRO:master Jun 21, 2019
@CygnusRoboticus CygnusRoboticus deleted the nz-input-group-bug branch June 21, 2019 14:02
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants