Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:tag): fix typo #3353

Merged
merged 1 commit into from
Apr 25, 2019
Merged

docs(module:tag): fix typo #3353

merged 1 commit into from
Apr 25, 2019

Conversation

olivewind
Copy link
Contributor

@olivewind olivewind commented Apr 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

image

Issue Number: N/A

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Apr 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2abc6d5

https://deploy-preview-3353--ng-zorro-master.netlify.com

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #3353 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3353   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         606      606           
  Lines       11931    11931           
  Branches      869      869           
=======================================
  Hits        11626    11626           
  Misses        196      196           
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e72f70...2abc6d5. Read the comment docs.

@olivewind
Copy link
Contributor Author

@wendzhue hi, guy, what else do I need to do before merging this pr?

@wzhudev
Copy link
Member

wzhudev commented Apr 25, 2019

@olivewind You don't have to anything more. We would merge this before next release. Thanks again!

@vthinkxie vthinkxie merged commit f155337 into NG-ZORRO:master Apr 25, 2019
@olivewind olivewind deleted the fix/typo branch April 25, 2019 14:46
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants