Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:radio): children unable to focus in radio label #2850

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

hsuanxyz
Copy link
Member

close #2774

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2774

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5753fca

https://deploy-preview-2850--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #2850 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage    95.5%   95.48%   -0.02%     
==========================================
  Files         523      523              
  Lines       12236    12237       +1     
  Branches     1668     1668              
==========================================
- Hits        11686    11685       -1     
- Misses        197      198       +1     
- Partials      353      354       +1
Impacted Files Coverage Δ
components/radio/nz-radio.component.ts 98.3% <100%> (+0.02%) ⬆️
components/radio/nz-radio-group.component.ts 90% <0%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f21d0...5753fca. Read the comment docs.

@hejinzhi
Copy link

请问大概什么时候能合并,谢谢

@vthinkxie vthinkxie merged commit 58743b8 into NG-ZORRO:master Jan 30, 2019
@hsuanxyz hsuanxyz deleted the doc/fix-radio-input branch April 22, 2019 02:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadioGroup More... Input bug
3 participants