fix(schematics): compatible with old version options #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 7f4bd0b |
Codecov Report
@@ Coverage Diff @@
## master #2622 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 495 495
Lines 12053 12053
Branches 1685 1685
=======================================
Hits 11524 11524
Misses 169 169
Partials 360 360Continue to review full report at Codecov.
|
JLHwung
reviewed
Dec 12, 2018
| @@ -22,7 +22,7 @@ export function registerLocale(options: Schema): Rule { | |||
| const appModulePath = getAppModulePath(host, getProjectMainFile(project)); | |||
| const moduleSource = getSourceFile(host, appModulePath); | |||
|
|
|||
| const locale = options.locale || 'en_US'; | |||
| const locale = options.locale || options.i18n || 'en_US'; | |||
There was a problem hiding this comment.
I suggest you could start to deprecate i18n options since v7.0.0 and remove it completely on v8.0.0. Basically we do not refuse breaking chang but breaking changes should be made cautiously and migration phrase should be offered to downstream.
Personally I am glad that --i18n is replaced by --locale --- it is more accurate then the previous term.
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* fix(schematics): compatible with old version options * refactor: add deprecated warn and format code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information