Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:core,tabs): not use re-exported operators from cdk #241

Merged
merged 1 commit into from
Sep 7, 2017
Merged

refactor(module:core,tabs): not use re-exported operators from cdk #241

merged 1 commit into from
Sep 7, 2017

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Sep 6, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

Using operators re-exported (and type-enhanced) from cdk.

What is the new behavior?

Cdk operators are only designed for StrictRxChain usage, which does not cover all available operators and not guaranteed by documentation (availability could change during time).

It would cause breaking change once cdk adjust the operators re-exported.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 40.985% when pulling efc2f6c on trotyl:remove-cdk-operators into 0180e1c on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 2f031ce into NG-ZORRO:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants