refactor(module:all): support Angular 7.0 #2372

vthinkxie · 2018-10-29T03:22:37Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

codecov · 2018-10-29T03:38:56Z

Codecov Report

Merging #2372 into next will decrease coverage by <.01%.
The diff coverage is 96.27%.

@@            Coverage Diff             @@
##             next    #2372      +/-   ##
==========================================
- Coverage   95.85%   95.84%   -0.01%     
==========================================
  Files         485      487       +2     
  Lines       12299    12318      +19     
  Branches     1671     1663       -8     
==========================================
+ Hits        11789    11806      +17     
- Misses        150      152       +2     
  Partials      360      360

Impacted Files	Coverage Δ
components/core/polyfill/match-media.ts	`22.22% <0%> (-2.78%)`	⬇️
components/tree/nz-tree.component.ts	`95.12% <100%> (ø)`	⬆️
components/modal/nz-modal.component.ts	`95.74% <100%> (+0.42%)`	⬆️
components/table/nz-td.component.ts	`100% <100%> (ø)`	⬆️
components/popconfirm/nz-popconfirm.component.ts	`100% <100%> (ø)`	⬆️
components/menu/nz-submenu.component.ts	`95.45% <100%> (ø)`	⬆️
components/tree/nz-tree-node.component.ts	`95.3% <100%> (ø)`	⬆️
components/card/nz-card-loading.component.ts	`100% <100%> (ø)`	⬆️
...te-picker/lib/popups/date-range-popup.component.ts	`95.16% <100%> (-0.03%)`	⬇️
components/grid/nz-row.component.ts	`100% <100%> (ø)`	⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb8548...0b79b80. Read the comment docs.

KhaledSMQ · 2018-10-29T17:40:05Z

i am facing issue on production build on production only

main.168dac91807e83b9a739.js:1 ERROR Error: Uncaught (in promise): Error: StaticInjectorError[t -> t]:
StaticInjectorError(Platform: core)[t -> t]:
NullInjectorError: No provider for t!
Error: StaticInjectorError[t -> t]:
StaticInjectorError(Platform: core)[t -> t]:
NullInjectorError: No provider for t!

i think related to select drop down (user example)

vthinkxie · 2018-10-30T04:27:52Z

ref #2381

* docs: update NG-ZORRO logo (#2425) * fix(module:collapse): can't fold up active panel with accordion (#2440) close #2437 * chore: update styles(ant-design 3.10.7) (#2432) * chore: update styles(ant-design 3.10.8) (#2475) * feat: Adds danish locale (#2486) close #2485 * fix(module:menu): fix dropdown menu item selected className (#2434) close #2433 * fix(module:list): fix invalid render empty style when unspecified data source (#2415) close #2385 * docs(module:modal): add missing nzClassName property (#2400) * docs: add faq in icons docs (#2459) * fix(module:menu): fix fold menu (#2454) close #2449 * refactor(module:all): use cdk keycodes instead of magic number (#2499) * release(1.8.1): release 1.8.1 (#2523) * chore: update styles(ant-design 3.10.9) (#2525) * fix(readme): fix misspelling (#2472) * refactor(module:all): support Angular 7.0 (#2372) * refactor(module:all): refactor component to support onPush & SSR * refactor(module:badge): refactor badge * refactor(module:button & card): refactor * test(module:button): fix test case * fix(module:avatar): fix avatar * fix(module:tree): fix tree tslint * fix(module:tree): fix tree module * fix(module:all): fix tslint config * refactor(module:all): upgrade to angular 7.0 * fix(module:all): fix typescript error * fix(module:build): fix build less options * fix(module:integration): fix webpack test * build: rm unused package * build: fix build & ci * test(module:spin): fix test error * docs: update readme * refactor(module:checkbox): support checkbox onPush (#2478) * docs: update NG-ZORRO logo (#2425) * fix(module:collapse): can't fold up active panel with accordion (#2440) close #2437 * chore: update styles(ant-design 3.10.7) (#2432) * refactor(module:checkbox): support checkbox onPush * refactor(module:collapse): support onPush in collapse (#2481) * refactor(module:divider): refactor divider (#2482) ref #2381 * refactor(module:form): refactor form (#2493) * refactor(module:grid): refactor grid module (#2498) * refactor(module:layout): refactor layout (#2500) * feat(module:progress): support custom strokeColor and strokeLinecap (#2404) close #2378 * feat(module:avatar): support custom size (#2416) close #2380 * fix(module:timeline): fix loading icon (#2386) close #2377 * feat(module:drawer): add input property in NzDrawerRef (#2464) close #2403 * refactor(module:radio): refactor radio to support OnPush (#2519) * refactor(module:spin): refactor spin (#2530) * refactor(module:alert & card): refactor card & refactor template outlet (#2532) * refactor(module:switch & checkbox): refactor switch & checkbox (#2533) * refactor(module:core): refactor input convert decorators (#2535) ref #2474 * refactor(module:mention): refactor mention (#2510) ref: #2381 * refactor(module:steps): refactor steps (#2512) ref #2381 * feat(module:modal): support clicking ESC to close modal (#2483) close #1999 * refactor(module:breadcrumb): refactor breadcrumb (#2513) ref #2381 * refactor(module:skeleton): refactor skeleton (#2514) ref #2381 * refactor(module:icon): refactor icon (#2517) ref #2381 * refactor(module:tree-select): refactor tree-select (#2528) ref: #2381 * build: bump webpack integration (#2524) build: bump webpack integration * refactor(module:timeline): refactor timeline (#2515) close #2379 * support alternate positions, alternate and right alternate * support reversing * refactor(module:autocomplete): refactor autocomplete (#2505) ref #2381, close #2420 * refactor(module:cascader): refactor cascader (#2516) * refactor(module:cascader): refactor cascader close #2935 ref #2198 * fix(module:cascader): fix isFocused access * refactor(module:avatar): refactor avatar (#2536) * fix(module:avatar): fix text style * refactor(module:avatar): refactor avatar ref: #2381 * refactor(module:upload): refactor upload (#2555) * refactor(module:upload): refactor upload - feat: add `nzOpenFileDialogOnClick` prop to allow setting whether to open the upload dialog when the component is clicked * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:list): refactor list (#2548) * refactor(module:list): refactor list * fix: import scrolling in share module * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:transfer): refactor transfer (#2553) * refactor(module:transfer): refactor transfer - feat: add nzDisabled property - need verify design details, ant-design/ant-design#13330 * chore: search muse be disabled * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:back-top): refactor back-top (#2547) refactor(module:back-top): refactor back-top * refactor(module:anchor): refactor anchor (#2546) * refactor(module:anchor): refactor anchor - feat: the nzTarget support string value - fix: invalid id in demo * chore: add encapsulation:ViewEncapsulation.None * chore: add encapsulation:ViewEncapsulation.None * chore: fix display style in host * chore: remove :host ref #2381 * refactor(module:affix): refactor affix (#2544) * refactor(module:affix): refactor affix - the nzTarget support string value * fix: release * style: removed no-any in first line * fix: fix style * chore: fix test * chore: fix display style in host * chore: remove :host

hsuanxyz · 2020-06-22T05:55:20Z

components/badge/nz-badge.component.ts

  maxNumberArray = [];
  countArray = [];
  countSingleArray = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 ];
  @ViewChild('contentElement') contentElement: ElementRef;
+  @Input() @InputBoolean() nzShowZero = false;
+  @Input() @InputBoolean() nzShowDot = true;


@vthinkxie 这里似乎加错了，以前 _showDot 对应的是 nzDot 没有 nzShowDot

* refactor(module:all): refactor component to support onPush & SSR * refactor(module:badge): refactor badge * refactor(module:button & card): refactor * test(module:button): fix test case * fix(module:avatar): fix avatar * fix(module:tree): fix tree tslint * fix(module:tree): fix tree module * fix(module:all): fix tslint config * refactor(module:all): upgrade to angular 7.0 * fix(module:all): fix typescript error * fix(module:build): fix build less options * fix(module:integration): fix webpack test * build: rm unused package * build: fix build & ci * test(module:spin): fix test error * docs: update readme

执衡 added 15 commits October 28, 2018 11:39

refactor(module:all): refactor component to support onPush & SSR

b37dba7

refactor(module:badge): refactor badge

b0b017d

refactor(module:button & card): refactor

5ad6e6f

test(module:button): fix test case

10c52e3

fix(module:avatar): fix avatar

82d2a38

fix(module:tree): fix tree tslint

274a821

fix(module:tree): fix tree module

4e136fc

fix(module:all): fix tslint config

b7095fd

refactor(module:all): upgrade to angular 7.0

e00c464

fix(module:all): fix typescript error

adc385e

fix(module:build): fix build less options

22ad650

fix(module:integration): fix webpack test

4ddaa47

build: rm unused package

182b1af

build: fix build & ci

e06c8e6

test(module:spin): fix test error

6e9f1d7

vthinkxie mentioned this pull request Oct 29, 2018

[WIP]refactor(module:all): refactor component to support onPush && Angular 7.0 #2267

Closed

15 tasks

docs: update readme

0b79b80

wzhudev mentioned this pull request Oct 29, 2018

NG-ZORRO Roadmap #2025

Closed

3 tasks

vthinkxie merged commit 3b8f9ea into NG-ZORRO:next Oct 29, 2018

vthinkxie mentioned this pull request Nov 1, 2018

MILESTONE: LATE 2018 #2381

Closed

86 tasks

vthinkxie deleted the refactor-all branch February 26, 2019 07:08

hsuanxyz reviewed Jun 22, 2020

View reviewed changes

pr-triage bot added the PR: unreviewed label Jun 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(module:all): support Angular 7.0 #2372

refactor(module:all): support Angular 7.0 #2372

vthinkxie commented Oct 29, 2018 •

edited

Loading

codecov bot commented Oct 29, 2018 •

edited

Loading

KhaledSMQ commented Oct 29, 2018

vthinkxie commented Oct 30, 2018

hsuanxyz Jun 22, 2020

vthinkxie Jun 22, 2020

refactor(module:all): support Angular 7.0 #2372

refactor(module:all): support Angular 7.0 #2372

Conversation

vthinkxie commented Oct 29, 2018 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

codecov bot commented Oct 29, 2018 • edited Loading

Codecov Report

KhaledSMQ commented Oct 29, 2018

vthinkxie commented Oct 30, 2018

hsuanxyz Jun 22, 2020

Choose a reason for hiding this comment

vthinkxie Jun 22, 2020

Choose a reason for hiding this comment

vthinkxie commented Oct 29, 2018 •

edited

Loading

codecov bot commented Oct 29, 2018 •

edited

Loading